feat: Add ability to enable Longhorn V2 Data Engine (backport #55) #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
Cherry-pick of fb60534 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Needed for #55 Signed-off-by: Tim Serong <[email protected]> (cherry picked from commit 0d0cfa2)
Signed-off-by: Tim Serong <[email protected]> (cherry picked from commit 97d8390)
This allows adding extra stages to oem/99_settings.yaml, independently of the NTP settings. Signed-off-by: Tim Serong <[email protected]> (cherry picked from commit fb60534) # Conflicts: # pkg/controller/nodeconfig/config/ntp.go
Signed-off-by: Tim Serong <[email protected]> (cherry picked from commit f45269c)
Related issue: harvester/harvester#5274 Signed-off-by: Tim Serong <[email protected]> (cherry picked from commit 75ec929)
tserong
force-pushed
the
mergify/bp/v0.3.x/pr-55
branch
from
bfdc37d
to
120ff96
Compare
|
I've manually fixed this so it also pulls in #56, and verified with: |
Vicente-Cheng
approved these changes
Aug 28, 2024
bk201
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
longhornConfigs.enableV2DataEngineto the node config CRD. When this value is set to true, we:It's probably easier to review this commit-by-commit, because I added some tests and did some refactoring first, to make sure I wasn't going to break the ntp config persistence.
Related issue: harvester/harvester#5274
This is an automatic backport of pull request #55 done by Mergify.